[PATCH] dsdb: Fix CID 1364520 Incorrect expression (EVALUATION_ORDER)

[Volker Lendecke]

Hi!

Something is definitely fishy here *lp_ctx=lp_ctx=talloc_get_type ? I
don't fully get the intent of this. Can someone explain? Or -- Review
appreciated!

Thanks, Volker
-------------- next part --------------
>From adf5c0811f1af94af66995a16e2f8eac8602744d Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 26 Jul 2016 12:42:49 +0200
Subject: [PATCH] dsdb: Fix CID 1364520 Incorrect expression (EVALUATION_ORDER)

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source4/dsdb/samdb/ldb_modules/password_hash.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/source4/dsdb/samdb/ldb_modules/password_hash.c b/source4/dsdb/samdb/ldb_modules/password_hash.c
index a6131e2..bb8679c 100644
--- a/source4/dsdb/samdb/ldb_modules/password_hash.c
+++ b/source4/dsdb/samdb/ldb_modules/password_hash.c
@@ -2215,9 +2215,8 @@ static int setup_password_fields(struct setup_password_fields_io *io)
 static int setup_smartcard_reset(struct setup_password_fields_io *io)
 {
 	struct ldb_context *ldb = ldb_module_get_ctx(io->ac->module);
-	struct loadparm_context *lp_ctx =
-		lp_ctx = talloc_get_type(ldb_get_opaque(ldb, "loadparm"),
-					 struct loadparm_context);
+	struct loadparm_context *lp_ctx = talloc_get_type(
+		ldb_get_opaque(ldb, "loadparm"), struct loadparm_context);
 	struct supplementalCredentialsBlob scb = { .__ndr_size = 0 };
 	enum ndr_err_code ndr_err;
 
-- 
2.1.4