[PATCH] Improve performance of GUID_to_ndr_blob() and similar

Andrew Bartlett abartlet at samba.org
Mon Jul 25 04:10:41 UTC 2016

Here we avoid a talloc, reduce the other from 1024 to 16 bytes and
avoid a talloc_steal().

This helps in tight loops in the AD DC ldb layers, particularly during
DRS replication of large numbers of links.  These O(N^2) loops should
be addressed as well, but this fix will also help in many other cases. 

Then, in the other patches, avoid talloc when not required elsewhere in
ldb extended DN parsing.

Please review and push.


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: guid_to_ndr_blob-and-ldb-perf.patch
Type: text/x-patch
Size: 33879 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160725/e3cdd56e/guid_to_ndr_blob-and-ldb-perf.bin>

More information about the samba-technical mailing list