smbclient_tar flapping

[Andrew Bartlett]

On Tue, 2016-06-21 at 18:09 +0200, Aurélien Aptel wrote:
> On Mon, 20 Jun 2016 16:47:31 -0700 Jeremy Allison <jra at samba.org>
> wrote:
> > Needs to be repeatable before I'll believe it I'm afraid.
> > More likely to be corruption in the testing EA store - remember
> > the 'D' bit is stored there in the dos attributes EA.
> 
> I also think it might me a tdb problem as selftest uses "store dos
> attributes = yes"
> and the tdb xattr VFS. I can also see this in logs when smbd looks
> for DOS attrs:
> 
> [10 2016/06/17 14:32:21.501261 ../source3/lib/xattr_tdb.c:183
> xattr_tdb_getattr]
>    xattr_tdb_getattr called for file 801:10051158:0, name
> system.fake_uid
> [10 2016/06/17 14:32:21.501276 ../source3/lib/xattr_tdb.c:189
> xattr_tdb_getattr]
>    xattr_tdb_fetch_attrs failed: NT_STATUS_INTERNAL_DB_CORRUPTION
> 
> Attached test script is repeatable as far as b1548fd (commit date in
> 2012) on my system.
> 
> - If the script is already in the repo at the commit you are testing,
> replace it.
> - If it's not add it at the same path and patch
> source3/selftest/tests.py
>   with attached patch.

Thank you so much for the test patch.  However, I think I have found the issue.

It is not safe to create files behind smbd's back when the vfs_xattr_tdb module is in use.  

The dev/inode may be re-used by the OS without the DB entry being wiped. 

Running the test in a private environment may help, but will just reduce the chances unless you always unlink via smbd.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba