PATCHES: Password sync as active directory domain controller

Stefan Metzmacher metze at
Fri Jul 22 10:32:54 UTC 2016

Hi Andrew,

> We can't have a grep of files in /proc in Samba.  Sorry.
> If you want mutual exclusion between the scripts, can you use a
> transaction lock over the ldb, or fcntl locks on another file?

I'm using fcntl locks now.

> Otherwise, the main thing I see is that autobuild doesn't run with --
> with-gpgme.  

It does it's autodetected if libgpgme11-dev is installed.

> Finally, after the episode, we should not accept 8-
> char key ids.  Please update the docs to only suggest 16-char IDs, and
> make the code refuse to accept < 16-char IDs.


> Otherwise, I'm finally OK with all this.  There is still a lot of code
> here, and some of it is pretty dense, but these are the only objections
> I have so far.  I really appreciate the efforts you have gone to to
> address my concerns.;a=shortlog;h=refs/heads/master4-gpgme
just needs review markers.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list