Patches to unify ACL handling in vfs_ceph + vfs_gluster

[Ira Cooper]

Forgot to git commit --amend that one :/.

I have the exact same fix locally.

Just passed my local build.

-Ira

On Thu, Jul 21, 2016 at 8:09 PM, Jeremy Allison <jra at samba.org> wrote:

> On Wed, Jul 20, 2016 at 08:46:11PM -0400, Ira Cooper wrote:
> > This is the patchset Zheng sent upstream earlier this year, with some
> > slight tweaks, mainly adding back in some important comments to the code.
> >
> > Please review,
>
> Nice work ! I can't test as I don't have gluster or ceph setups
> locally, but the code changes are clear enough (and a really
> nice refactoring to share the code between gluster and ceph) !
>
> Unfortunately doesn't compile on master due to:
>
> ../source3/modules/posixacl_xattr.c: In function
> ‘posixacl_xattr_acl_get_file’:
> ../source3/modules/posixacl_xattr.c:384:4: error: too few arguments to
> function ‘synthetic_smb_fname’
>     synthetic_smb_fname(frame, path_p, NULL, NULL);
>
> which means it needs updating to add in the
> flags field I added.
>
> Can you fix that up and resend ? It's just
> adding an extra zero parameter to:
>
> synthetic_smb_fname(frame, path_p, NULL, NULL);
>
> but I didn't want to push something I'd modified
> without you looking at it.
>
> Cheers,
>
>         Jeremy.
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: look2
Type: application/octet-stream
Size: 31101 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160721/2eb4ab3d/look2.obj>