[PATCH] smbd: Enable leases by default

Ralph Böhme slow at samba.org
Thu Jul 21 13:45:37 UTC 2016


On Thu, Jul 21, 2016 at 02:50:26PM +0200, Volker Lendecke wrote:
> On Fri, Jul 22, 2016 at 12:03:34AM +1200, Garming Sam wrote:
> > That appears as if you've dropped the manpage change that time.
> 
> Yes, that was the user error I was referring to.
> 
> Now I'm getting
> 
> [462(2252)/1939 at 37m26s] samba3.smb2.durable-open(ad_dc)
> UNEXPECTED(uxsuccess): samba3.smb2.durable-open.reopen1a-lease(ad_dc)
> 
> FAILED (0 failures, 0 errors and 1 unexpected successes in 0
> testsuites)
> 
> A summary with detailed information can be found in:
> 
> What shall we do here? Remove that test from knownfail, or create a
> separate environment with an explicit "smb2 leases = no"?

those tests are run against ad_dc and nt4_dc environments. The latter
is explicitly configured with leases enabled, the former uses the
default.

To preserve the setting in the environments while flipping the default
to enabled., simply adding "smb2 leases = no" to ad_dc seems like the
way to do it.

Cheerio!
-slow



More information about the samba-technical mailing list