[PATCH] smbd: Enable leases by default

Garming Sam garming at catalyst.net.nz
Thu Jul 21 12:03:34 UTC 2016

That appears as if you've dropped the manpage change that time.

source3/param/loadparm.c is still very much used, and the defaults 
loading needs to be made in common (there's still some subtle 
differences I believe), but no one's had the time or energy to do that. 
As far as the test goes, it all seems tedious, testing every default, 
but the test has, and continues to catch important bugs.



On 21/07/2016 11:28 p.m., Volker Lendecke wrote:
> Nope, same result:
> UNEXPECTED(failure): samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s4(none)
> REASON: Exception: Exception: Traceback (most recent call last):
>    File
> "/memdisk/vlendec/manual/b935011/samba/bin/python/samba/tests/docs.py",
> line 168, in test_default_s4
>      self._test_default(['bin/samba-tool', 'testparm'])
>    File
> "/memdisk/vlendec/manual/b935011/samba/bin/python/samba/tests/docs.py",
> line 199, in _test_default
>      "Parameters that do not have matching defaults:"))
> AssertionError: Parameters that do not have matching defaults:
>      smb2 leases
>        Expected: no
>        Got: YES
> FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
> Volker

More information about the samba-technical mailing list