[PATCH] smbd: Enable leases by default

Ralph Böhme slow at samba.org
Thu Jul 21 10:57:16 UTC 2016


On Thu, Jul 21, 2016 at 12:41:07PM +0200, Volker Lendecke wrote:
> On Wed, Jul 20, 2016 at 10:49:03PM +0200, Volker Lendecke wrote:
> > On Wed, Jul 20, 2016 at 10:38:06PM +0200, Ralph Böhme wrote:
> > > attached. Please review&push if ok together with Volker's original
> > > patch.
> > 
> > One typo, feautre vs feature, and we need to list the changed
> > parameter I believe.
> 
> Ok, this fails autobuild because the docs test does not pick up the
> new default. It expects true (as mentioned in smb.conf), but it does
> not see the change in loadparm.c.

the param subsystems are still a blackbox to me, but I guess this is
what's missing:

--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -2898,6 +2898,8 @@ struct loadparm_context *loadparm_init(TALLOC_CTX *mem_ctx)
 
        lpcfg_do_global_parameter(lp_ctx, "aio max threads", "100");
 
+       lpcfg_do_global_parameter(lp_ctx, "smb2 leases", "yes");
+
        /* Allow modules to adjust defaults */
        for (defaults_hook = defaults_hooks; defaults_hook;
                 defaults_hook = defaults_hook->next) {

Cheerio!
-slow



More information about the samba-technical mailing list