[PATCH] Making shares unaccessible at root level mountable (aka solving bsc#8950 ...again)

Pavel Shilovsky piastryyy at gmail.com
Tue Jul 19 19:21:26 UTC 2016

2016-07-18 17:38 GMT+03:00 Aurélien Aptel <aaptel at suse.com>:
> On Sat, 2 Jul 2016 10:02:36 +0300 Pavel Shilovsky
> <pshilovsky at samba.org> wrote:
>> Please remove this unnecessary change - probably it will go to stable
>> some day and may cause extra conflicts.
>> The above code should check for possible memory allocation failure.
> I've added (new patch attached) NULL checks and removed the gratuitous
> empty line.
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
> Nürnberg)

I suggest you to run scripts/checkpatch.pl against your patch - it has
several warnings like {} braces for single statement blocks. Also the
patch from the attachment still has an empty line in fs/cifs/cifsfs.c.

Best regards,
Pavel Shilovsky

More information about the samba-technical mailing list