[PATCH] CTDB scripting clean-ups and shellcheck tests

Martin Schwenke martin at meltin.net
Mon Jul 18 12:06:18 UTC 2016

On Mon, 18 Jul 2016 22:02:40 +1000, Martin Schwenke <martin at meltin.net>

> A small bunch of shellcheck fixes to CTDB's scripts went in recently.
> Following that I did a few more clean-ups.  Then Amitay and I decided
> that we might as well go all the way, get rid of all shellcheck
> warnings and add some tests to make sure the scripts stay that way.
> Attached are initial clean-ups.  This is part 1 - I'm splitting this to
> try to avoid message moderation limits.
> 2 replies to follow:
> * Part 2 - A series of commits to avoid shellcheck warnings
> * Part 3 - Addition of CTDB shellcheck test suite
> These can be applied on top of master in order.
> Please review and maybe push...

Part 3.  Tests have been run with shellcheck 0.3.7 and 0.4.4.

At the moment there are some extra warnings generated by 0.4.4.  These
are ignored by the test suite because they are difficult to handle,
involve too much churn for too little gain and/or are contentious.  I
might look at a couple of them later...

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb-scripts-3.patch
Type: text/x-patch
Size: 9641 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160718/cb4469f0/ctdb-scripts-3.bin>

More information about the samba-technical mailing list