[PATCH] CTDB scripting clean-ups and shellcheck tests

Martin Schwenke martin at meltin.net
Mon Jul 18 12:03:45 UTC 2016

On Mon, 18 Jul 2016 22:02:40 +1000, Martin Schwenke <martin at meltin.net>

> A small bunch of shellcheck fixes to CTDB's scripts went in recently.
> Following that I did a few more clean-ups.  Then Amitay and I decided
> that we might as well go all the way, get rid of all shellcheck
> warnings and add some tests to make sure the scripts stay that way.
> Attached are initial clean-ups.  This is part 1 - I'm splitting this to
> try to avoid message moderation limits.
> 2 replies to follow:
> * Part 2 - A series of commits to avoid shellcheck warnings
> * Part 3 - Addition of CTDB shellcheck test suite
> These can be applied on top of master in order.
> Please review and maybe push...

Part 2.  Cleans up all warnings generated by shellcheck 0.3.7.

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb-scripts-2.patch
Type: text/x-patch
Size: 82271 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160718/6ea91798/ctdb-scripts-2.bin>

More information about the samba-technical mailing list