[PATCH] CTDB scripting clean-ups and shellcheck tests

[Martin Schwenke]

A small bunch of shellcheck fixes to CTDB's scripts went in recently.
Following that I did a few more clean-ups.  Then Amitay and I decided
that we might as well go all the way, get rid of all shellcheck
warnings and add some tests to make sure the scripts stay that way.

Attached are initial clean-ups.  This is part 1 - I'm splitting this to
try to avoid message moderation limits.

2 replies to follow:

* Part 2 - A series of commits to avoid shellcheck warnings
* Part 3 - Addition of CTDB shellcheck test suite

These can be applied on top of master in order.

Please review and maybe push...

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb-scripts-1.patch
Type: text/x-patch
Size: 38256 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160718/9a4b9c6f/ctdb-scripts-1.bin>