[PATCH] three small ones from my attic

Michael Adam obnox at samba.org
Thu Jul 14 18:43:03 UTC 2016

On 2016-07-14 at 19:00 +0200, Volker Lendecke wrote:
> On Thu, Jul 14, 2016 at 05:17:41PM +0200, Michael Adam wrote:
> > Style-wise, I would like it better with tdb_read call
> > outside the if(...), and a helper variable for the ret,
> > but maybe you have good reasons for it?
> Introduced a helper variable.

Thanks - reads better, imho.

> > (similar comments to the above calls to
> > tdb_unlock and tdb_unlock_record).
> Those two are copy&paste from further down in the code. I opted for
> style consistency in the function rather than README.Coding coherence.
> > Regarding the call, the DOCONV() seems to be at least
> > different from the prior call to tdb_alloc_read()
> > (which internally sets 0 to the slot).
> > Is that something where the new code is better and
> > the alloc_read code needs fixing?
> That was a bug in my code, thanks!
> New patch attached.

Thanks! this is reviewed-by:me.

I will push later when my current autobuild is done
unless you or s/o else pushes before that.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/4080c4c9/signature.sig>

More information about the samba-technical mailing list