[WIP][PATCH] selftest: add clusteredmember (1-node) env

Michael Adam obnox at samba.org
Thu Jul 14 11:23:39 UTC 2016


On 2016-07-14 at 12:47 +0200, Michael Adam wrote:
> On 2016-07-14 at 11:53 +0200, Ralph Boehme wrote:
> > Hi Michael,
> > 
> > great work!
> > 
> > On Wed, Jul 13, 2016 at 02:52:02AM +0200, Michael Adam wrote:
> > > On 2016-07-13 at 10:25 +1000, Martin Schwenke wrote:
> > > > Hi Michael,
> > > > 
> > > > On Tue, 12 Jul 2016 16:41:11 +0200, Michael Adam <obnox at samba.org>
> > > > wrote:
> > > > 
> > > > > here is the current WIP state of my clusteredmember
> > > > > selftest environment.
> > > > >
> > > > > [...]
> > > > >
> > > > > But I appreciate any comments / hints!
> > > > 
> > > > I'm working on trying to understand this to see what common code we can
> > > > use between this and ctdb/tests/simple/scripts/local_daemons.bash.  I
> > > > figure we should be able to factor out all of the CTDB provisioning
> > > > code...
> > > 
> > > Yeah in the long run, that might be the way to go.
> > > 
> > > But since this version of the patch seems to work
> > > reliably for me now, we might want to bring it
> > > upstream first and refactor later.
> > 
> > works until it breaks. :)
> > 
> > I have a pending patch that fixes restarting cleanupd in a cluster on
> > a node that is banned.
> 
> Ok, cool.
> 
> > Branch with the fix, your patches and an added test for my patch on
> > top:
> > <https://git.samba.org/?p=slow/samba.git;a=shortlog;h=refs/heads/cleanupd>
> > 
> > On my system configured with --prefix=/opt/samba this breaks at:
> > 
> > $ make test TESTS=ctdb_ban
> > ...
> > UNEXPECTED(failure):
> > samba3.blackbox.ctdb_ban(clusteredmember:local).ctdb_ban(clusteredmember:local)
> > REASON: Exception: Exception: ../ctdb/client/ctdb_client.c:293 Failed
> > to connect client socket to daemon. Errno:No such file or directory(2)
> > ../ctdb/common/cmdline.c:167 Failed to connect to daemon
> > Failed to init ctdb
> > Failed to read nodes file "/opt/samba/etc/ctdb/nodes"
> > Is this node part of a CTDB cluster?
> 
> > Guess we're still missing your patches for ctdb build with a prefix !=
> > /usr ?
> 
> Well, as you can see in the Samba3.pm, you need to tell
> ctdb this:
>  - --socket=<location of ctdbd socket> as cmdline option
>  - CTDB_NODES=<location of nodes file> in env
>    or
>    CTDB_BASE=<directory containing nodes file> in env
> 
> Will propose such an update to your test later.

Attached patch (to be squashed with yours) fixes
the calling of ctdb.

But the test does not succeed currently, since this is about
ip-reallocation, and the clusteredmember does not do public
addresses (yet), and it also doe not to reallocations because
it is currently a 1-node setup... ?! :-)

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/40561880/signature.sig>


More information about the samba-technical mailing list