Tautological comparison in gcc 6.1.1

Andrew Bartlett abartlet at samba.org
Wed Jul 13 09:57:48 UTC 2016


On Wed, 2016-07-13 at 14:21 +1000, Amitay Isaacs wrote:

> Reviewed-by: me.
> 
> Let's wait and see if anyone has a better idea.
> 
> Amitay.

Build some files with -Wno-tautological-compare?

The problem with the solutions I've seen proposed is that they just
wait for the compiler to get smarter, or the -O level to be raised, and
then we are back where we started.  It also makes elegant code less
-elegant.

I know there are advantages to finding these things elsewhere, but it
frustrates me when changes like this are need (mostly the follow-up
patches, if we just had to change the inside of the macros I wouldn't
mind so much). 

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list