[samba-team/samba] pvfs_open win10 fix, need return SMB2_CREATE_TAG_QFID (#61)

[Jeremy Allison]

On Tue, Jul 12, 2016 at 02:38:09PM -0700, Samba Team Github Bot wrote:
> On Mon, 2016-07-11 at 03:16 -0700, kkHAIKE wrote:
> > Signed-off-by: kkhaike kkhaike at gmail.com
> > You can view, comment on, or merge this pull request online at:
> >   https://github.com/samba-team/samba/pull/61
> > Commit Summary
> > pvfs_open win10 fix, need return SMB2_CREATE_TAG_QFID
> > File Changes
> > M source4/libcli/raw/interfaces.h (4)
> > M source4/ntvfs/ntvfs_generic.c (2)
> > M source4/ntvfs/posix/pvfs_open.c (18)
> > M source4/smb_server/smb/nttrans.c (1)
> > M source4/smb_server/smb/reply.c (1)
> > M source4/smb_server/smb2/fileio.c (5)
> > Patch Links:
> > https://github.com/samba-team/samba/pull/61.patch
> > https://github.com/samba-team/samba/pull/61.diff
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub, or mute the thread.
> 
> Thanks.  This looks really good.
> 
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
> Can I get a second team reviewer please?

It's close - but the hunks that do:

+       if (io->generic.in.query_on_disk_id) {
+               ZERO_ARRAY(io->generic.out.on_disk_id);
+               SIVAL(io->generic.out.on_disk_id, 0, name->st.st_ino);
+               SIVAL(io->generic.out.on_disk_id, 8, name->st.st_dev);
+       }

Need to be:

+       if (io->generic.in.query_on_disk_id) {
+               ZERO_ARRAY(io->generic.out.on_disk_id);
+               SBVAL(io->generic.out.on_disk_id, 0, name->st.st_ino);
+               SBVAL(io->generic.out.on_disk_id, 8, name->st.st_dev);
+       }

Use SBVAL() not SIVAL(). The dev/ino fields are 8 bytes here,
not 4. Can you resubmit with that change ?