[PATCH] s3-messaging/ctdb is broken in master

Ralph Boehme slow at samba.org
Mon Jul 11 17:16:26 UTC 2016


On Sun, Jul 10, 2016 at 10:21:49PM +0200, Volker Lendecke wrote:
> On Sun, Jul 10, 2016 at 02:40:08PM +0200, Ralph Boehme wrote:
> > > Of course it looks good, however -- why do you remove the error
> > > information by always doing "return EIO;" instead of "return ret;"?
> > 
> > sorry, obviously wrong, updated patchset attached.
> 
> Reviewed-by: Me.
> 
> Not pushing, I'd love to see the strerror(ret) as part of all the
> newly introduced DBG statements, like you have it in patch 3/5 for
> example. With that in, feel free to push with my Reviewed-by.

good idea, updated and pushed.

Cheerio!
-slow



More information about the samba-technical mailing list