Improve badPwdCount, lastLogon and logonCount updates
abartlet at samba.org
Thu Jul 7 19:30:54 UTC 2016
On Thu, 2016-07-07 at 18:25 +0200, Stefan Metzmacher wrote:
> Hi Andrew,
> > > > > I've reviewed the bulk of these for pwdLastSet, and have
> > > > > started
> > > > > an
> > > > > autobuild with them, except for the code to force specific
> > > > > replPropertyMetaData values, which both didn't seem to be
> > > > > related
> > > > > and
> > > > > broke the repl_move test.
> > > >
> > > > Can you be more specific about that? what did you skip? What
> > > > did it
> > > > break?
> > >
> > > Run 'make test TESTS=repl_move'
> > >
> > > The check for expected replPropertyMetaData values in particular.
> I've fix the problem with repl_move.
> It seems Windows creates a metadata stamp for logonHours on add
> even when it's not present.
> Should pass now. I'm currently doing a private autobuild.
I really appreciate your efforts here. These look good, expect a
positive review and push on these shortly.
While not your job at all, if you have any clues as to why, after these
fixes, the tombstone reanimation behaviour has changed, that would be
I'm hoping to get tombstone_reanimate restored for Samba 4.5, and the
restored tests fail with:
REASON: Exception: Exception: Traceback (most recent call last):
py", line 364, in test_restore_user
self.assertAttributesEqual(obj, attr_orig, obj_restore, attr_rest)
py", line 88, in assertAttributesEqual
AssertionError: Actual object does not have expected attributes,
missing from expected (set(['pwdLastSet'])), extra (set())
I'm sure I can figure it out - presumably pwdLastSet moved from some
common code to a special case - but any clues give me more time to
review your other patches ;-)
The git tree is:
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical