[PATCH] Fix schema reload (cause of many flapping tests)

Andrew Bartlett abartlet at samba.org
Wed Jul 6 11:04:12 UTC 2016

On Wed, 2016-07-06 at 12:45 +0200, Andreas Schneider wrote:
> On Wednesday, 6 July 2016 11:52:55 CEST Andrew Bartlett wrote:
> > The attached patches appear to finally fix our schema reloading,
> > which
> > has been causing a number of flapping tests, particularly in
> > repl_move
> > (which makes a lot of replications). 
> > 
> > I do wish to apologise for the delay in getting this resolved.
> Thanks for fixing this. I can give RB+ for the first two patches, for
> the rest 
> I do not know the code well enough to comment.
> I would need someone to explain it first.

Thanks for that.  Garming reviewed the rest for me just as we finished
up the work day, and I have these in the same autobuild as your krb5
patches, with your review as indicated.

The schema re-loading code appears to be contortion piled upon

As an example, I had to pull it from the autobuild due to a build
strictness issue we can fix trivially tomorrow, but Garming found and
removed even more ugly hacks trying to reload our schema at 'just the
right time'. 

The plan with the new code is to use only this schema sequence number,
and not other heuristics or time-based settings.


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list