[PATCH] CTDB log message improvements

[Richard Sharpe]

On Mon, Jul 4, 2016 at 12:00 AM, Amitay Isaacs <amitay at gmail.com> wrote:
> Hi,
>
> Here are two changes to log messages.
>
> Please review and push.
>
> Amitay.

I am confused by the wording in this hunk:

@@ -1606,12 +1606,14 @@ int32_t ctdb_control_set_recmaster(struct ctdb_context *
ctdb, uint32_t opcode, T

  if (ctdb->pnn != new_recmaster && ctdb->recovery_master == ctdb->pnn) {
  DEBUG(DEBUG_NOTICE,
-      ("This node (%u) is no longer the recovery master\n", ctdb
->pnn));
+      ("Local node %u is now the recovery master\n",
+       new_recmaster));
  }

  if (ctdb->pnn == new_recmaster && ctdb->recovery_master != new_recmaster
) {
  DEBUG(DEBUG_NOTICE,
-      ("This node (%u) is now the recovery master\n", ctdb->pnn)
);
+      ("Remote node %u is now the recovery master\n",
+       ctdb->pnn));
  }

  ctdb->recovery_master = new_recmaster;

What local node are you referring to? The one the log is printed on?

Wouldn't it be better to say: "This node (%u) is now the recovery master"?


-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)