[PATCH] CTDB IP address allocation clean-up

Martin Schwenke martin at meltin.net
Mon Jul 4 10:30:15 UTC 2016


On Mon, 4 Jul 2016 16:39:33 +1000, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Mon, Jul 4, 2016 at 12:45 PM, Martin Schwenke <martin at meltin.net> wrote:
> 
> > The attached patch set does 2 overlapping things:
> >
> > * Cleans up the API to the IP address and makes the CTDB IP allocation
> >   state an opaque structure
> >
> > * Cleans up the IP allocation test code and removes the "#include
> >   most of the server code" approach by linking to the ctdb-ipalloc
> >   subsystem
> >
> > Please review and maybe push...
> >
> > peace & happiness,
> > martin
> >  
> 
> Looks good.  Been waiting too long to get rid of tests/src/ctdbd_test.c.
> 
> Pushed to autobuild.

Fell over in:

[2(6)/1928 at 0s] samba.tests.docs
UNEXPECTED(error): samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s4(none)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/memdisk/amitay/a/b501911/samba/bin/python/samba/tests/docs.py", line 171, in test_default_s4
  File "/memdisk/amitay/a/b501911/samba/bin/python/samba/tests/docs.py", line 309, in _set_arbitrary
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
ERROR: test failed with exit code 1

Never seen that before!

Re-pushed...

peace & happiness,
martin



More information about the samba-technical mailing list