[PATCH] fix a bug in smbget

Andreas Schneider asn at samba.org
Thu Jan 28 08:59:18 UTC 2016


On Wednesday 27 January 2016 23:00:37 Christian Ambach wrote:
> Am 26.01.16 um 12:26 schrieb Andreas Schneider:
> >> Right, that is not consistent and should be improved and stream-lined to
> >> the other tools we have.
> > 
> > See attached patch ...
> 
> Looks good, I re-attached it with my Reviewed-By: (and a slight chang in
> the description of the encrypt option) as part of a patchset with more
> patches that fix up the rcfile parsing and manpages to review so they
> can finally be pushed together.

Looks good. I've pushed it to autobuild with some minor fixes. Like fixing 
line length in commit messages and in the manpage I changed -U for --update to 
-u.

> 
> > I have to work on another printing bug now. Could you add some blackbox
> > tests for smbget?
> 
> I'll see what I can do.

Thanks!


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list