[PATCH] DRAFT: Add new test which covers force user bug

[Uri Simchoni]

Hi Robin,

>   	if ($unix_uid < 0xffff - 5) {
>   		$max_uid = 0xffff;
I think you also want to fix that to:

  	if ($unix_uid < 0xffff - 7) {

(my bad for not updating to -6 in a recently added test)
> @@ -1271,6 +1286,7 @@ sub provision($$$$$$$$)
>   	$uid_pdbtest2 = $max_uid - 4;
>   	$uid_userdup = $max_uid - 5;
>   	$uid_pdbtest_wkn = $max_uid - 6;
> +	$uid_force_user = $max_uid - 7;
>   
>   	if ($unix_gids[0] < 0xffff - 7) {
>   		$max_gid = 0xffff;
likewise

> +	print "DONE\n";
> +
That should be deleted - it refers to the whole process of setting up 
test env.

> --- /dev/null
> +++ b/source3/script/tests/test_forceuser_validusers.sh
It appears to me that the essence of this new test suite is to perform a 
successful tree-connect to the force_user_valid_users share, using 
$USERNAME/$PASSWORD credentials. Can't it be just added as another test 
to an existing test suite that tests similar things using similar 
techniques? Good candidates are:
- samba3.blackbox.valid_users
- samba3.blackbox.smbclient_auth.plain

(actually I think the two test suites should be merged, or that all 
"force user" test should be combined in a separate test suite, where it 
can be verified not only that the tree-connect succeeds, but also that 
the force-user works, e.g. by creating a file and doing smbcacls on it - 
but that can be done later. In the meantime I don't see a reason for 
adding another test suite)

Thanks,
Uri.

On 01/08/2016 12:56 PM, Robin Hack wrote:
> HI all.
>
> Thank you for review.
>
> I discovered other bugs so I decided to do some changes:
> * test were moved to fileserver test env
> * new samba/unix accound named force_user were created
>     - change solves previous issue with make test TESTS=samba3.local.nss
>     - additionally it solves "bug" in test itself. While setup, 2 groups
> with same GID were created which is not nice and taint test env
> * test script were renamed to:
> samba3.blackbox.smbclient.forceuser_validusers
>    - user name has been hard coded but set of arguments for script remains
> (it's for future use :))
>
> New patch is attached.
>
> Have nice day
> Robin Hack
>
>