[PATCH] s3:smbd:open: Skip redundant call to file_set_dosmode when creating a new file.

José A. Rivera jarrpa at samba.org
Tue Jan 26 13:28:16 UTC 2016

Hey folks,

Attached is a tiny, seemingly benign patch to open.c. Yes, that open.c. 
The patch has been pair-programmed with Ira and already reviewed by 
but this is definitely a case where more eyes can't hurt.

The patch changes an if clause to only set the DOS archive attribute 
open if the file was overwritten. We believe this logic makes sense, 
that opened files don't need to have the archive bit re-set and newly 
files are taken care of by the logic around line 2468.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: skip_redundant_dosmode.patch
Type: text/x-diff
Size: 1299 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160126/84bc8292/skip_redundant_dosmode.diff>

More information about the samba-technical mailing list