[PATCH] fix a bug in smbget

Andreas Schneider asn at samba.org
Tue Jan 26 11:26:06 UTC 2016


On Monday 25 January 2016 22:48:34 Christian Ambach wrote:
> Hi Andreas,

Hey Christian,

> 
> > The problem is username and password parsing from the command line. If you
> > specify it at the moment, smbget will still ask for it.
> 
> I cannot reproduce that:
> # smbget -v -R -u ambi -p Passw0rd smb://192.168.56.101/Share
> works for me without further questions.

Ok, than your change fixes it!
 
> Right, that is not consistent and should be improved and stream-lined to
> the other tools we have.

See attached patch ...

I have to work on another printing bug now. Could you add some blackbox tests 
for smbget?


Cheers,

	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: master_fix_smbget_cmdline_parsing.patch
Type: text/x-patch
Size: 14393 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160126/dd2889bd/master_fix_smbget_cmdline_parsing.bin>


More information about the samba-technical mailing list