[PATCHES] multi-channel: implement network interface info ioctl

[Michael Adam]

On 2016-01-25 at 18:09 +0530, Anoop C S wrote:
> On Mon, 2016-01-25 at 13:09 +0100, Michael Adam wrote:
> > Updated complete patchset attached:
> > 
> > - correctly (according to current samba) translate NOT_SUPPORTED
> >   into NT_STATUS_FS_DRIVER_REQUIRED or
> >   NT_STATUS_INVALID_DEVICE_REQUEST
> > 
> > - get if_index from the kernel
> > - make it possible to override from the config
> > - fall back to calculation 0x80000000 + count as suggested
> >   if neither in kernel nor in config
> > 
> 
> I think you missed to copy if_index in the following change from patch
> 10 inside add_interfaces().
> 
>  	iface->ip = ifs->ip;
>  	iface->netmask = ifs->netmask;
>  	iface->bcast = ifs->bcast;
> +	iface->linkspeed = ifs->linkspeed;
> +	iface->capability = ifs->capability;
>  
>  	DLIST_ADD(local_interfaces, iface);

Thanks, correct!

This copying should be in a different patch anyways.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160125/7466365e/signature.sig>