[PATCHES] multi-channel: implement network interface info ioctl

Anoop C S anoopcs at redhat.com
Mon Jan 25 12:39:11 UTC 2016


On Mon, 2016-01-25 at 13:09 +0100, Michael Adam wrote:
> Updated complete patchset attached:
> 
> - correctly (according to current samba) translate NOT_SUPPORTED
>   into NT_STATUS_FS_DRIVER_REQUIRED or
>   NT_STATUS_INVALID_DEVICE_REQUEST
> 
> - get if_index from the kernel
> - make it possible to override from the config
> - fall back to calculation 0x80000000 + count as suggested
>   if neither in kernel nor in config
> 

I think you missed to copy if_index in the following change from patch
10 inside add_interfaces().

 	iface->ip = ifs->ip;
 	iface->netmask = ifs->netmask;
 	iface->bcast = ifs->bcast;
+	iface->linkspeed = ifs->linkspeed;
+	iface->capability = ifs->capability;
 
 	DLIST_ADD(local_interfaces, iface);

Thanks
--Anoop C S



More information about the samba-technical mailing list