[PATCHES] multi-channel: implement network interface info ioctl

[Michael Adam]

On 2016-01-25 at 10:36 +0100, Stefan Metzmacher wrote:
> 
> Ok, one more thing, do we want to implement
> FSCTL_QUERY_NETWORK_INTERFACE_INFO if
> xconn->client->server_multi_channel_enabled
> is false?

I was thinking about this, too.
I can of course make it dependent on multi channel enabled.
But also in the MS-SMB2 doc, I can't find reference to
this behaviour. And would it harm?

> Otherwise reviewed/signed-off by me.

Thanks!

> >> The correct handling for if_index will come later?
> > 
> > Well, I thouhgt about it for a while.
> > But I am not sure what the 'correct' handling is.
> > What relevance and value would it be for a client
> > to know that number instead of a made-up one.
> > We do have a patch that gets the if index from the
> > kernel. But what about the case of an interface
> > that is only specified via the interfaces line?
> > In that case we would need to make an index up
> > for this interface and make sure not to collide
> > with any of those from the kernel.
> 
> Just start with 0x80000000 for the ones not comming from the kernel.
> In addition to speed and capabilities we can also have a if_index=350
> option.

Sure, that is possible.
I assume that 350 is an example value here?
I thought about this too, but wanted to start off as
simple as possible.

> One more question what is the value behind
> "Speed: Unknown!" which is reported with "Link detected: no"
> 
> I think we should filter out disconnected interfaces in the FSCTL call.

Good point.
Do you think we can add that as improvements (a little) later on?

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160125/2ce82e53/signature.sig>