[PATCH] fix a bug in smbget

Andreas Schneider asn at samba.org
Mon Jan 25 07:06:31 UTC 2016


On Sunday 24 January 2016 23:08:16 Christian Ambach wrote:
> Hi list,

Hi Christian,
 
> the attached patchset contains a fix and some code cleanup for smbget.
> The first patch fixes the actual bug that the recursive download only
> works if the local username equals the username to be used for the SMB
> server to connect to.
> The rest of the patches are code cleanups to adopt the code to the
> coding standards and to make use of some C99 features.

I will review your patchset. I've started with smbget cleanup ~5 weeks ago. 
But I first tried to fix the option parsing, as it is broken too.

Maybe you want to take a look at:

https://git.samba.org/?p=asn/samba.git;a=commitdiff;h=7b9453c6510a99875cf0beef73bb2ab8476f1c6f


Cheers,


	-- andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list