[PATCH] Introduce smbspool_krb5_wrapper bug #11690

[Ralph Boehme]

On Fri, Jan 22, 2016 at 11:11:35PM +0100, Andreas Schneider wrote:
> On Friday, January 22, 2016 10:26:42 PM Ralph Boehme wrote:
> > On Fri, Jan 22, 2016 at 10:18:30PM +0100, Andreas Schneider wrote:
> > > On Friday, January 22, 2016 05:03:07 PM Ralph Boehme wrote:
> > > > Hi!
> > > 
> > > Hi Ralph,
> > > 
> > > > Nice work!
> > > 
> > > thanks.
> > > 
> > > > I may be completely off, but wouldn't it make sense to
> > > > 
> > > > On Fri, Jan 22, 2016 at 04:38:30PM +0100, Andreas Schneider wrote:
> > > > > +	return execv("/usr/bin/smbspool", argv);
> > > > 
> > > > preserve PATH and use execvp("smbspool", argv) instead in order to
> > > > avoid having the patch hardcoded?
> > > 
> > > Yes, good idea. Or we could pass the install prefix to it. Do you want to
> > > implement it or should I do it on Monday? :-)
> > 
> > it's your patchset, I'm just nitpicking. :)))
> 
> How about this?

> From 8416364c265153f6197cbceb72bb4eb338618096 Mon Sep 17 00:00:00 2001
> From: Andreas Schneider <asn at samba.org>
> Date: Fri, 22 Jan 2016 23:04:50 +0100
> Subject: [PATCH 1/2] waf: Add BINDIR to config.h

hm, I thinkg get_dyn_BINDIR() should do the trick.

I'm not sure this is actually different from hardcoding /usr/bin.

We have a few places where we use execvp().

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de