[PATCH] Introduce smbspool_krb5_wrapper bug #11690

Andreas Schneider asn at samba.org
Fri Jan 22 21:26:56 UTC 2016


On Friday, January 22, 2016 05:03:07 PM Ralph Boehme wrote:
> Hi!
> 
> Nice work!
> 
> I may be completely off, but wouldn't it make sense to
> 
> On Fri, Jan 22, 2016 at 04:38:30PM +0100, Andreas Schneider wrote:
> > +	return execv("/usr/bin/smbspool", argv);
> 
> preserve PATH and use execvp("smbspool", argv) instead in order to
> avoid having the patch hardcoded?

Security wise is the hardcoded path better. Maybe really better use the 
compile prefix and pass it as a cflag during compilation or add it to config.h


	-- andreas



More information about the samba-technical mailing list