[PATCH] Fix for bug 11684

[Ralph Boehme]

On Fri, Jan 22, 2016 at 12:30:27PM -0800, Jeremy Allison wrote:
> On Fri, Jan 22, 2016 at 01:55:59PM +0100, Andreas Schneider wrote:
> > On Friday 22 January 2016 10:29:07 Ralph Boehme wrote:
> > > On Fri, Jan 22, 2016 at 10:11:15AM +0100, Michael Adam wrote:
> > > > On 2016-01-22 at 07:14 +0100, Volker Lendecke wrote:
> > > > > On Thu, Jan 21, 2016 at 01:59:15PM -0800, Jeremy Allison wrote:
> > > > > > Thanks for doing the tests. Nothing like facts in a
> > > > > > heated debate :-).
> > > > > > 
> > > > > > Unfortunately 14.04 is a LTS version, so this damn
> > > > > > bug will be around for a while.
> > > > > > 
> > > > > > Volker, is {} for new code acceptible for you ?
> > > > > 
> > > > > If it is not possible to remove -Werror for these files,
> > > > 
> > > > This would certainly be possible, technically.
> > > > 
> > > > But why sacrifice the protection we have by -Werror
> > > > just because of a few lines? Wouldn't it be better
> > > > to use s/th that works for the broken compiler and
> > > > still is standards compliant without giving up on -Werror?
> > > 
> > > I'm really against removing -Werror.
> > > 
> > > As said, using {{0}} in this case fixes the issue and is standard
> > > compliant. It's a nuisance, but it's the best we can do.
> > 
> > I'm for this solution!
> 
> +1 from me too. I don't want to lose -Werror.
> 
> Ralph, can you push with that change to your
> code ?

if nobody else disagrees I'll push tomorrow.

Thanks everyone!
-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de