[PATCH] Fix for bug 11684

Andreas Schneider asn at samba.org
Fri Jan 22 12:55:59 UTC 2016


On Friday 22 January 2016 10:29:07 Ralph Boehme wrote:
> On Fri, Jan 22, 2016 at 10:11:15AM +0100, Michael Adam wrote:
> > On 2016-01-22 at 07:14 +0100, Volker Lendecke wrote:
> > > On Thu, Jan 21, 2016 at 01:59:15PM -0800, Jeremy Allison wrote:
> > > > Thanks for doing the tests. Nothing like facts in a
> > > > heated debate :-).
> > > > 
> > > > Unfortunately 14.04 is a LTS version, so this damn
> > > > bug will be around for a while.
> > > > 
> > > > Volker, is {} for new code acceptible for you ?
> > > 
> > > If it is not possible to remove -Werror for these files,
> > 
> > This would certainly be possible, technically.
> > 
> > But why sacrifice the protection we have by -Werror
> > just because of a few lines? Wouldn't it be better
> > to use s/th that works for the broken compiler and
> > still is standards compliant without giving up on -Werror?
> 
> I'm really against removing -Werror.
> 
> As said, using {{0}} in this case fixes the issue and is standard
> compliant. It's a nuisance, but it's the best we can do.

I'm for this solution!

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list