[PATCHES] SMB3 Multi-Channel: session binding
Ralph Boehme
rb at sernet.de
Fri Jan 22 08:20:53 UTC 2016
Hi Michael,
great to see this moving forward! :)
I was just wondering whether this:
On Fri, Jan 22, 2016 at 01:28:47AM +0100, Michael Adam wrote:
> + if (protocol >= PROTOCOL_SMB2_22 && SMBD_IS_MULTI_CHANNEL_CAPABLE) {
> + if (in_capabilities & SMB2_CAP_MULTI_CHANNEL) {
> + capabilities |= SMB2_CAP_MULTI_CHANNEL;
> + }
> + }
> +
is right. Shouldn't we compared against PROTOCOL_SMB3_00?
Besides that, the global used to disable MC seems somewhat unelegant
to me. I guess there isn't a nicer way of achieving the same goal?
-Ralph
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de
More information about the samba-technical
mailing list