[PATCH] vfs_shadow_copy2: add snapsharepath parameter

Michael Adam obnox at samba.org
Thu Jan 21 20:44:55 UTC 2016

On 2016-01-14 at 07:23 +0200, Uri Simchoni wrote:
> Hi,
> This is something that's been in my queue for some time waiting for the
> vfs_shadow_copy2 fixes to get pushed. It adds some needed flexibility in
> locating the share's files in a snapshot.
> Michael - I submit it now hoping that all the path arithmetic is still in
> your L2 or L3 cache (although it doesn't drastically change anything).
> Review appreciated.
> Thanks,
> Uri.

I had started to review this but did not complete yet.

> From f2ba7515c2dd1c2e8c55b16a1f0d2aa4f223e7cf Mon Sep 17 00:00:00 2001
> From: Uri Simchoni <uri at samba.org>
> Date: Tue, 3 Nov 2015 10:42:00 +0200
> Subject: [PATCH 2/5] vfs_shadow_copy2: check crossmountpoints against
>  snapdirseverywhere
> If crossmountpoints is enabled, verify that snapdirseverywhere is
> enabled too, since crossmountpoints has no meaning otherwise.
> This obviates the check of crossmountpoints against other config
> variables.
> Signed-off-by: Uri Simchoni <uri at samba.org>

This one I have rebased to the bottom and pushed.

The other ones, I am not 100% sure yet I agree with.

I don't see yet that the snapsharepath really gains anything.
Will follow up with details.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160121/46bfce18/signature.sig>

More information about the samba-technical mailing list