[PATCH] Fix for bug 11684

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jan 21 19:16:54 UTC 2016

On Thu, Jan 21, 2016 at 09:48:55AM -0800, Jeremy Allison wrote:
> > > That's a gcc bug. We need to disable -Werror for this file.
> > 
> > alternatively we can remove the 0. Is it ok if I push the patchset
> > with that modification?
> Good catch Ralph, thanks. 'Reviewed-by: Jeremy Allison <jra at samba.or>
> (I'm OK without the { 0 }).

NACK. {} is non-standard, other compilers will not accept this. If
we need to be compatible everywhere, including buggy gcc, we need to
remove the struct initializers again and go with ZERO_STRUCT/explicit
member assignment. Maybe in the end the change to C99 was a bad idea.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list