[PATCH] Fix shared object clashes - read_data()

Alexander Bokovoy ab at samba.org
Thu Jan 21 18:27:20 UTC 2016


On Thu, 21 Jan 2016, Jeremy Allison wrote:
> > > diff --git a/source4/dsdb/samdb/ldb_modules/wscript_build_server b/source4/dsdb/samdb/ldb_modules/wscript_build_server
> > > index b54d27f..8fa9939 100755
> > > --- a/source4/dsdb/samdb/ldb_modules/wscript_build_server
> > > +++ b/source4/dsdb/samdb/ldb_modules/wscript_build_server
> > > @@ -325,7 +325,7 @@ bld.SAMBA_MODULE('ldb_acl',
> > >  	init_function='ldb_acl_module_init',
> > >  	module_init_name='ldb_init_module',
> > >  	internal_module=False,
> > > -	deps='talloc samba-security samdb DSDB_MODULE_HELPERS krb5samba'
> > > +	deps='talloc samba-util samba-security samdb DSDB_MODULE_HELPERS krb5samba'
> > >  	)
> > Can we rename read_data to something more unique?
> 
> Nah, we've been using read_data() forever (longer than
> gnutls has been in existence :-).
I realize you are half-joking but we had to change libpdb recently
because there is a library with that name in computational biology
field, so there is a precedent of sorts already.

How closely tied you are to read_data()? :)

-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list