[PATCH] selftest: Rename heimdal blackbox tests and only run them if we build against heimdal

Michael Adam obnox at samba.org
Thu Jan 21 09:09:17 UTC 2016

On 2016-01-21 at 09:59 +0200, Alexander Bokovoy wrote:
> On Tue, 19 Jan 2016, Andreas Schneider wrote:
> > Hi,
> > 
> > attached find two patches which rename the heimdal blackbox tests and runs 
> > them only in the case we built with heimdal support.
> > 
> > Review and push appreciated!
> Even though we had an argument with Andreas over being able to review if
> you did co-authored the patches, I'm giving in and providing my
> Reviewed-by here.

If you co-authored, then you should probably be mentioned
via "Pair-programmed-with: ..." and the patch should
also carry your signed-off-by. Team signed-off-by's count
like team reviewed-by's. (If instead you were just marginally
involved in authoring the patches, it would imho be perfectly
valid to review it and give r-b.)

So a patch that has been pair-programmed by two team-members
and carries both their signoff-tags formally carries enough
team-review/signoff to be pushed to master. What most people
do with such pre-reviewed patches in order to play nicely with
the community is presenting such patches to samba-technical
and pushing if no-one commented after a while (a day or so).

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160121/1c41a87a/signature.sig>

More information about the samba-technical mailing list