[PATCHESv2]vfs: separate fs stats from quota in vfs modules

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Jan 19 20:46:17 UTC 2016

On Mon, Jan 18, 2016 at 11:15:56PM +0200, Uri Simchoni wrote:
> Hi,
> Attached is V2 of the refactoring. Changes were made only to the
> mock module (As per Volker's suggestion - to use smb.conf and
> lp_parm_XX() for mock configuration rather than a custom config file
> and custom config code), and conversely to the test framework (but
> not to the tests themselves). The mock module is greatly simplified
> by this change.
> The building of the tests is also squashed now to fewer commits.

This looks really good now. Only very few cosmetic comments: In the module
there's a few if's without {}. Also, right now we prefer "False->false",
"(True)->true". Last one: What about building this only in developer mode?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list