[PATCH] s3:vfs_fileid: add "fstype/mntdir deny/allow list" option

Ralph Wuerthner ralphw at de.ibm.com
Mon Jan 18 13:18:54 UTC 2016

On 15/01/16 01:14, Jeremy Allison wrote:
> On Thu, Jan 14, 2016 at 04:31:36PM +0100, Ralph Wuerthner wrote:
>> Hello,
>> please see attached patch to fix an issue we encountered recently at a
>> customer.
>> Regards
>> 	Ralph
>> PS: an alternative solution would be to pass the file path and the
>> SMB_STRUCT_STAT to the file_id_create function. This way no additional
>> options would be required, but I don't know if it's worth the effort to
>> change all file_id_create calls.
> Ugh. I gotta say I hate this :-). So this is a fix for Samba
> because NFS is utterly unreliable and causes clients to hang
> in the D wait-state ?
> This might be better as a local or IBM-specific patch :-).
> Or is the utility worth working around in Samba ?
> What do others think ?

As Volker mentioned: when vfs_fileid is used, _all_ mounted file systems
will get a stat() and statfs() - regardless if the file system is
exported or not. With this patch it will be possible to exclude those
unrelated file systems from being accessed.



More information about the samba-technical mailing list