[PATCH] Fix pwdLastSet behaviour in regards to Windows
Douglas Bagnall
douglas.bagnall at catalyst.net.nz
Mon Jan 18 06:36:28 UTC 2016
hi Adrian,
There is one thing you missed:
> On 2016-01-18 12:28, Douglas Bagnall wrote:
>>> + unix_to_nt_time(&now, time(NULL));
>>> + asprintf(&now_s, "%" PRIu64, (uint64_t) now);
>>
>> This should be talloc_asprintf(). And check for errors.
You've switched to talloc_asprintf, but it still doesn't check whether
it succeeds.
Another minor thing is there are still these functions with the curly
bracket in the wrong place:
> +static int operational_add(struct ldb_module *ctx, struct ldb_request *req) {
> +static int operational_modify(struct ldb_module *ctx, struct ldb_request *req) {
I like assertApprox, btw.
Douglas
More information about the samba-technical
mailing list