[PATCH] s3:vfs_fileid: add "fstype/mntdir deny/allow list" option
ralphw at de.ibm.com
Fri Jan 15 09:36:53 UTC 2016
On 15/01/16 09:34, Ralph Boehme wrote:
> On Thu, Jan 14, 2016 at 04:14:45PM -0800, Jeremy Allison wrote:
>> On Thu, Jan 14, 2016 at 04:31:36PM +0100, Ralph Wuerthner wrote:
>>> please see attached patch to fix an issue we encountered recently at a
>>> PS: an alternative solution would be to pass the file path and the
>>> SMB_STRUCT_STAT to the file_id_create function. This way no additional
>>> options would be required, but I don't know if it's worth the effort to
>>> change all file_id_create calls.
>> Ugh. I gotta say I hate this :-). So this is a fix for Samba
>> because NFS is utterly unreliable and causes clients to hang
>> in the D wait-state ?
>> This might be better as a local or IBM-specific patch :-).
>> Or is the utility worth working around in Samba ?
>> What do others think ?
> Would it be possible to modify SMB_VFS_FILE_ID_CREATE() adding a
> pathname parameter and statfs() that directly?
I did a quick check and there are about thirty places were
SMB_VFS_FILE_ID_CREATE() is called via vfs_file_id_from_sbuf(). And we
do not have a struct smb_fname available in all places. So this would
result in a large code change and I don't know if it's worth the effort
as vfs_fileid is only used in very few Samba installations.
More information about the samba-technical