[PATCH] s3:vfs_fileid: add "fstype/mntdir deny/allow list" option

Scott Lovenberg scott.lovenberg at gmail.com
Fri Jan 15 01:19:10 UTC 2016


On Thu, Jan 14, 2016 at 6:14 PM, Jeremy Allison <jra at samba.org> wrote:
>
> On Thu, Jan 14, 2016 at 04:31:36PM +0100, Ralph Wuerthner wrote:
> > Hello,
> >
> > please see attached patch to fix an issue we encountered recently at a
> > customer.
> >
> > Regards
> >
> >       Ralph
> >
> > PS: an alternative solution would be to pass the file path and the
> > SMB_STRUCT_STAT to the file_id_create function. This way no additional
> > options would be required, but I don't know if it's worth the effort to
> > change all file_id_create calls.
>
> Ugh. I gotta say I hate this :-). So this is a fix for Samba
> because NFS is utterly unreliable and causes clients to hang
> in the D wait-state ?
>
> This might be better as a local or IBM-specific patch :-).
>
> Or is the utility worth working around in Samba ?
>
> What do others think ?

For better or, more often worse, there are a lot of environments out
there that re-export NFS.  Maybe if it were named more NFS specific?
It doesn't hurt anything other than adding to the documentation and
man page and the code isn't really complicated or large.  My $0.02.

-- 
Peace and Blessings,
-Scott.



More information about the samba-technical mailing list