[PATCH] ldb: Fix CID 1348110 Uninitialized scalar variable

Jeremy Allison jra at samba.org
Thu Jan 14 20:28:25 UTC 2016


On Thu, Jan 14, 2016 at 09:13:12PM +0100, Volker Lendecke wrote:
> Hi!
> 
> Review appreciated!
> 
> Thanks, Volker

LGTM. Pushed !





> From 97b12c1a7afcff19ade250eb5c328b37031e3dce Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Thu, 14 Jan 2016 21:10:39 +0100
> Subject: [PATCH] ldb: Fix CID 1348110 Uninitialized scalar variable
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  lib/ldb/common/ldb_dn.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c
> index 5bf72ac..b7d2de7 100644
> --- a/lib/ldb/common/ldb_dn.c
> +++ b/lib/ldb/common/ldb_dn.c
> @@ -1916,7 +1916,7 @@ int ldb_dn_set_component(struct ldb_dn *dn, int num,
>  		return LDB_ERR_OTHER;
>  	}
>  
> -	if (v.length > v.length + 1) {
> +	if (val.length > val.length + 1) {
>  		return LDB_ERR_OTHER;
>  	}
>  
> -- 
> 1.7.9.5
> 




More information about the samba-technical mailing list