[PATCH] shadow_copy2: fix the manpage
obnox at samba.org
Wed Jan 13 08:31:10 UTC 2016
On 2016-01-13 at 09:11 +0200, Uri Simchoni wrote:
> Hmmm, thanks for figuring this out. I should really start writing tests in
> Python... :)
> The thing that kept me from writing Python tests is that I wasn't sure
> what's the "proper" way of doing it (I mean, not just write a python script
> instead of a shell script hook into the unittest-based infrastructure) and I
> decided to just stay with shell...
I like Volker's source3/script/tests/test_wbinfo_sids2xids_int.py
quite a lot. It is a simple replacement of shell code, called by
a very slim shell wrapper source3/script/tests/test_wbinfo_sids2xids.sh
Of course, more advanced or conecptually better way would be
great. But then, we should first think about our test framework
in general. The current scheme that all tests for an environment
use the same environment after it has been brought up and keep
tainting it, instead of proper setup and teardown functions
and having dedicated smaller environments for each test suite
seem much more problematic for me.
> Anyway, at this stage, if bash is fine I would just switch to bash. Would
> you like me to re-submit a corrected patch?
Already did that.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: not available
More information about the samba-technical