[PATCH] shadow_copy2: fix the manpage
uri at samba.org
Wed Jan 13 07:11:11 UTC 2016
Hmmm, thanks for figuring this out. I should really start writing tests
in Python... :)
The thing that kept me from writing Python tests is that I wasn't sure
what's the "proper" way of doing it (I mean, not just write a python
script instead of a shell script hook into the unittest-based
infrastructure) and I decided to just stay with shell...
Anyway, at this stage, if bash is fine I would just switch to bash.
Would you like me to re-submit a corrected patch?
On 01/13/2016 08:53 AM, Michael Adam wrote:
> On 2016-01-13 at 08:21 +0200, Uri Simchoni wrote:
>> This and the next one are RB+ me, and pushed to autobuild. Autobuild seems
>> to be failing (both Volker's patches that I pushed yesterday and apparently
>> the shadow-copy patches) - I've re-pushed and am re-trying on a local
> My autobuild with your shadow_copy patches failed on the new shadow_copy test.
> But it succeeded locally on my box. The reason for this is that
> the test_shadow_copy script uses arrays, which is not supported
> by the dash (which /bin/sh points to on the ubuntu test host).
> I would simply re-push with /bin/sh replaced by /bin/bash.
> I don't think this is a big problem: It would be the first of
> the samba scripts to use bash, but the ctdb-tests are mostly
> written in bash.
> Or would you want to rewrite the script without using arrays?
> Cheers - Michael
More information about the samba-technical