[PATCH] shadow_copy2: fix the manpage

Michael Adam obnox at samba.org
Wed Jan 13 06:53:04 UTC 2016

On 2016-01-13 at 08:21 +0200, Uri Simchoni wrote:
> This and the next one are RB+ me, and pushed to autobuild. Autobuild seems
> to be failing (both Volker's patches that I pushed yesterday and apparently
> the shadow-copy patches) - I've re-pushed and am re-trying on a local
> machine.

My autobuild with your shadow_copy patches failed on the new shadow_copy test.
But it succeeded locally on my box. The reason for this is that
the test_shadow_copy script uses arrays, which is not supported
by the dash (which /bin/sh points to on the ubuntu test host).

I would simply re-push with /bin/sh replaced by /bin/bash.
I don't think this is a big problem: It would be the first of
the samba scripts to use bash, but the ctdb-tests are mostly
written in bash.

Or would you want to rewrite the script without using arrays?

Cheers - Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160113/b05af312/signature.sig>

More information about the samba-technical mailing list