[PATCHES]vfs: separate fs stats from quota in vfs modules

Jeremy Allison jra at samba.org
Tue Jan 12 20:24:10 UTC 2016

On Tue, Jan 12, 2016 at 01:18:24PM +0100, Volker Lendecke wrote:
> On Tue, Jan 12, 2016 at 01:55:20PM +0200, Uri Simchoni wrote:
> > I'm not exactly sure what's your concern with the current implementation
> "Concern" is too strong a word. It's just that I see a slight duplication
> of concepts with the dfq_params struct and its members. Enums, names,
> structs -- I would understand that effort if this was speed-critical
> in production code that also needs properly documented parameters.
> The "add get_quota imlementation" has to extend the enum and the array. If
> another aspect comes along even more will be required. lp_parm_int has
> its overhead, so I would not do it in a hot code path, but for test code
> it would be perfectly fine.

As this is a mock module for testing purposes, I'm OK
with the current implementation which leaves the
complexity in the module and inside the .dfq file
inside the directory being tested.

I actually found Uri's implementaion of that
rather elegant (you have to admit that re-using
the pm_process() code for this is rather clever :-),
and one of the reasons I praised the code in the
first place :-).

However, I'm not going to step on toes by pushing
stuff that you and Volker are still discussing,
so let me know if you want to do another round,
changing the config to an "include" directive
in the smb.conf or want to keep the existing
file-based method.

If I had to chose I'd prefer the file based
method as I think it isolates the complexity needed
better, but I'm not writing the code, only
reviewing, so I'll go with Uri's choice.

I had a visit last week with a vendor who specifically
asked for a tidyup of the quotas code and I initially
had to say it wasn't on the horizon so I'm really
glad to see this coming out now. Almost like their
wishes got granted by magic :-).

I'd love to see a version of this go in soon.



More information about the samba-technical mailing list