[PATCHES]vfs: separate fs stats from quota in vfs modules

Uri Simchoni uri at samba.org
Tue Jan 12 11:55:20 UTC 2016


I'm not exactly sure what's your concern with the current implementation 
(whether it's simplicity/elegance or the dependence on pm_process or 
something else) but I'm beginning to like the idea of using lp_parm, 
albeit in a bit unorthodox way.

Bear in mind that I need per-folder parameters, not per-share 
parameters, so I will need to somehow encode the path name in the 
parameter key. It seems like simply concatenating the path to the 
parameter name would work for .conf files. For example to find parameter 
"df block size" in folder foo/bar, I can do lp_parm_ulonglong(snum, 
"dfq", "df block size/foo/bar"). The unorthodox thing is use of '/' and 
'.' in the key.

As for the concern of clobbering smb.conf (and the concern of polluting 
the env for other tests if the conf changes while a test is running) - I 
can use an include directive, and reload conf between tests and after 
the test suite.

Pls let me know what you think of this.


On 01/12/2016 08:20 AM, Volker Lendecke wrote:
> On Mon, Jan 11, 2016 at 02:10:55PM -0800, Jeremy Allison wrote:
>> Still reviewing this but I just wanted to say how nice
>> it is to see the patch structured this way with the
>> mock VFS module providing the framework for a test environment.
>> I've learned a lot reading this code - thanks !
> My only comment on this code so far: Can we solve
> configuration of the mock module a bit differently? For
> example with lp_parm_int calls? If we don't want to clobber
> the test smb.conf too much, you could use the registry with
> "net conf" before and after the test.
> Volker

More information about the samba-technical mailing list