[PATCHES]vfs: separate fs stats from quota in vfs modules

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Jan 12 06:20:17 UTC 2016


On Mon, Jan 11, 2016 at 02:10:55PM -0800, Jeremy Allison wrote:
> Still reviewing this but I just wanted to say how nice
> it is to see the patch structured this way with the
> mock VFS module providing the framework for a test environment.
> 
> I've learned a lot reading this code - thanks !

My only comment on this code so far: Can we solve
configuration of the mock module a bit differently? For
example with lp_parm_int calls? If we don't want to clobber
the test smb.conf too much, you could use the registry with
"net conf" before and after the test.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list